Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference/sql: update modify column docs for prohibit modifying the precision of decimals #1790

Merged
merged 5 commits into from
Sep 10, 2019
Merged

reference/sql: update modify column docs for prohibit modifying the precision of decimals #1790

merged 5 commits into from
Sep 10, 2019

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Aug 22, 2019 •
edited by lilin90
Loading

What is changed, added or deleted?

reference/sql: update modify column docs for prohibit modifying the precision of decimals

Related PR: pingcap/tidb#10433

What is the related PR or file link(s)?

Which version does your change affect?

dev, v3.0, v2.1

@crazycs520
Copy link
Contributor Author

@zimulala PTAL

@lilin90 lilin90 added the translation/doing This PR’s assignee is translating this PR. label Sep 2, 2019
zimulala
zimulala reviewed Sep 6, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid
Copy link
Contributor

AilinKid commented Sep 6, 2019

LGTM

lilin90
lilin90 approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 merged commit c4738b2 into pingcap:master Sep 10, 2019
@lilin90 lilin90 mentioned this pull request Sep 10, 2019
Merged
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 10, 2019
@lilin90 lilin90 self-assigned this Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@lilin90 lilin90 lilin90 approved these changes

Assignees

@lilin90 lilin90

Labels
translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crazycs520 @AilinKid @zimulala @lilin90 @yikeke